Remove flush_async workaround as it is no longer needed in newer ACPP versions#333
Merged
Remove flush_async workaround as it is no longer needed in newer ACPP versions#333
Conversation
|
Check-perf-impact results: (ae6918621b46271c2f10d6eb978fe95d) ❓ No new benchmark data submitted. ❓ |
Contributor
|
The coverage reporting run is currently failing not because of anything on our side, but because coveralls.io seems to have problems. Since this PR doesn't substantially change anything about coverage we could still merge it, but that would mean that the main build would be red, so let's wait a bit to see if this clears up. |
Pull Request Test Coverage Report for Build 16966111156Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
flush_asyncworkaround for newer ACPP versions, as the asynchronous submission worker thread was removed in Acpp PR #1798.Maintains compatibility with older ACPP versions.